Contributing to Bitcoin ABC

The Bitcoin ABC project welcomes contributors!

This guide is intended to help developers contribute effectively to Bitcoin ABC.

Communicating with Developers

To get in contact with ABC developers, we monitor a telegram supergroup. The intent of this group is specifically to facilitate development of Bitcoin-ABC, and to welcome people who wish to participate.

https://t.me/joinchat/HCYr50mxRWjA2uLqii-psw

Acceptable use of this supergroup includes the following:

It is not for:

Bitcoin ABC Development Philosophy

Bitcoin ABC aims for fast iteration and continuous integration.

This means that there should be quick turnaround for patches to be proposed, reviewed, and committed. Changes should not sit in a queue for long.

Here are some tips to help keep the development working as intended. These are guidelines for the normal and expected development process. Developers can use their judgement to deviate from these guidelines when they have a good reason to do so.

Here are some handy links for development practices aligned with Bitcoin ABC:

Getting set up with the Bitcoin ABC Repository

  1. Create an account at https://reviews.bitcoinabc.org/

  2. Install Git and Arcanist on your machine

Git documentation can be found at: https://git-scm.com/

Arcanist documentation can be found at: https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/

And: https://secure.phabricator.com/book/phabricator/article/arcanist/

To install these packages on Debian or Ubuntu, type: sudo apt-get install git arcanist

  1. If you do not already have an SSH key set up, follow these steps:

Type: ssh-keygen -t rsa -b 4096 -C "your_email@example.com"

Enter a file in which to save the key (/home/username/.ssh/id_rsa): [Press enter]

  1. Upload your SSH public key to reviews.bitcoinabc.org

Paste contents from: /home/*username*/.ssh/id_rsa.pub

  1. Clone the repository and install Arcanist certificate:
git clone ssh://vcs@reviews.bitcoinabc.org:2221/source/bitcoin-abc.git

cd bitcoin-abc

arc install-certificate

Note: Arcanist tooling will tend to fail if your remote origin is set to something other than the above. A common mistake is to clone from Github and then forget to update your remotes.

Follow instructions provided by arc install-certificate to provide your API token.

  1. Code formatting tools

During submission of patches, arcanist will automatically run arc lint to enforce Bitcoin ABC code formatting standards, and often suggests changes. If code formatting tools do not install automatically on your system, you will have to install the following:

On Ubuntu (>= 18.04+updates):

sudo apt-get install clang-format-8 clang-tidy-8 clang-tools-8 cppcheck python-autopep8 flake8 php-codesniffer yamllint

On Debian (>= 10), the clang-8 family of tools is available from the buster-backports repository:

echo "deb http://deb.debian.org/debian buster-backports main" | sudo tee -a /etc/apt/sources.list
sudo apt-get update
sudo apt-get install cppcheck python-autopep8 flake8 php-codesniffer
sudo apt-get -t buster-backports install clang-format-8 clang-tidy-8 clang-tools-8

If not available in the distribution, clang-format-8 and clang-tidy can be installed from https://releases.llvm.org/download.html or https://apt.llvm.org.

For example, for macOS:

curl http://releases.llvm.org/8.0.0/clang+llvm-8.0.0-x86_64-apple-darwin.tar.xz | tar -xJv
ln -s $PWD/clang+llvm-8.0.0-x86_64-apple-darwin/bin/clang-format /usr/local/bin/clang-format
ln -s $PWD/clang+llvm-8.0.0-x86_64-apple-darwin/bin/clang-tidy /usr/local/bin/clang-tidy

If you are modifying a shell script, you will need to install the shellcheck linter. A recent version is required and may not be packaged for your distribution. Standalone binaries are available for download on the project’s github release page: https://github.com/koalaman/shellcheck/releases

Note: In order for arcanist to detect the shellcheck executable, you need to make it available in your PATH; if another version is already installed, make sure the recent one is found first. Arcanist will tell you what version is expected and what is found when running arc lint against a shell script.

If you are running Debian 10, it is also available in the backports repository:

sudo apt-get -t buster-backports install shellcheck

Working with The Bitcoin ABC Repository

A typical workflow would be:

You should add suggested reviewers and a test plan to the commit message. Note that Arcanist is set up to look only at the most-recent commit message, So all you changes for this Diff should be in one Git commit.

What to work on

If you are looking for a useful task to contribute to the project, a good place to start is the list of tasks at https://reviews.bitcoinabc.org/maniphest/

You could also try backporting some code from Bitcoin Core.

By contributing to this repository, you agree to license your work under the MIT license unless specified otherwise in contrib/debian/copyright or at the top of the file itself. Any work contributed where you are not the original author must contain its license header with the original author(s) and source.

Disclosure Policy

See DISCLOSURE_POLICY.